Skip to content

chore: flip use_cxx11_abi naming #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zewenli98 merged 2 commits into from
Jan 22, 2025
Merged

chore: flip use_cxx11_abi naming #3361

zewenli98 merged 2 commits into from
Jan 22, 2025

Conversation

@zewenli98
Copy link
Collaborator

@zewenli98 zewenli98 commented Jan 18, 2025

Description

flip use_cxx11_abi naming

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Jan 18, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation component: build system Issues re: Build system component: api [Python] Issues re: Python API labels Jan 18, 2025
@github-actions github-actions bot requested a review from gs-olive January 18, 2025 02:33
@zewenli98 zewenli98 removed the request for review from gs-olive January 18, 2025 02:34
@zewenli98 zewenli98 mentioned this pull request Jan 18, 2025
Closed
narendasan
narendasan reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be changes to .bazelrc

@zewenli98
Copy link
Collaborator Author

zewenli98 commented Jan 21, 2025

There needs to be changes to .bazelrc

@narendasan .bazelrc uses cxx11_abi as default. Only when specifying --config=python or --config=pre_cxx11_abi, it will compile using pre_cxx11_abi. Where do you think should be changed?

@narendasan
Copy link
Collaborator

narendasan commented Jan 21, 2025

Its that --config=python now needs to use the cxx11 abi

@zewenli98 zewenli98 force-pushed the flip_use_cxx11_abi_as_default branch from 43f2352 to 1fe6625 Compare January 22, 2025 00:06
@zewenli98 zewenli98 merged commit cfdb585 into main Jan 22, 2025
68 checks passed
@zewenli98 zewenli98 deleted the flip_use_cxx11_abi_as_default branch January 12, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan left review comments

@peri044 peri044 Awaiting requested review from peri044

@lanluo-nvidia lanluo-nvidia Awaiting requested review from lanluo-nvidia

Assignees

@zewenli98 zewenli98

Labels

cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zewenli98 @narendasan @facebook-github-bot