Skip to content

fix: export USE_CXX11_ABI=1 for cuda12.6 #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: export USE_CXX11_ABI=1 for cuda12.6 #3319

merged 1 commit into from
Dec 12, 2024

Conversation

zewenli98
Copy link
Collaborator

@zewenli98 zewenli98 commented Dec 12, 2024 •
edited
Loading

Description

export USE_CXX11_ABI=1 for cuda12.6

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Dec 12, 2024
@zewenli98 zewenli98 requested a review from narendasan December 12, 2024 02:40
narendasan
narendasan approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit a945aeb into main Dec 12, 2024
65 of 71 checks passed
@narendasan narendasan deleted the fix_CXX11_ABI branch December 12, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@zewenli98 zewenli98

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zewenli98 @narendasan @facebook-github-bot