Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 3259 #3260

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix issue 3259 #3260

merged 3 commits into from
Oct 29, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia commented Oct 23, 2024

Description

Fixes # (issue) #3259
Also added testcases to capture the issue

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added the component: tests Issues re: Tests label Oct 23, 2024
@narendasan
Copy link
Collaborator

narendasan commented Oct 23, 2024

Users would avoid this error if they switched from inputs to arg_inputs right? yes.

@narendasan
Copy link
Collaborator

We probably need to add error handling such that both arg inputs and inputs dont have something at the same time

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure to cherry pick onto 2.5

@lanluo-nvidia lanluo-nvidia merged commit 2840531 into main Oct 29, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants