add more logs

core/plugins/register_plugins.cpp

@@ -20,7 +20,7 @@ class TorchTRTPluginRegistry {
     // Plugins outside this subset in TensorRT are not being logged in this. So temporarily we disable this to prevent
     // multiple logging of same plugins. To provide a clear list of all plugins, we iterate through getPluginRegistry()
     // where it prints the list of all the plugins registered in TensorRT with their namespaces.
-    plugin_logger.set_reportable_log_level(util::logging::LogLevel::kERROR);
+    plugin_logger.set_reportable_log_level(util::logging::LogLevel::kDEBUG);
     initLibNvInferPlugins(&plugin_logger, "");
     plugin_logger.set_reportable_log_level(util::logging::get_logger().get_reportable_log_level());
 

core/runtime/register_jit_hooks.cpp

@@ -93,7 +93,7 @@ TORCH_LIBRARY(tensorrt, m) {
   m.def("get_cudagraphs_mode", []() -> bool { return CUDAGRAPHS_MODE; });
   m.def("set_cudagraphs_mode", [](bool cudagraphs_mode) -> void { CUDAGRAPHS_MODE = cudagraphs_mode; });
   m.def("set_logging_level", [](int64_t level) -> void {
-    util::logging::get_logger().set_reportable_log_level(util::logging::LogLevel(level));
+    util::logging::get_logger().set_reportable_log_level(util::logging::LogLevel::kDEBUG);
   });
   m.def(
       "get_logging_level", []() -> int64_t { return int64_t(util::logging::get_logger().get_reportable_log_level()); });

py/torch_tensorrt/_compile.py

@@ -384,7 +384,6 @@ def cross_compile_save_for_windows(
         file_path,
         arg_inputs=torchtrt_arg_inputs,
         enabled_precisions=enabled_precisions_set,
-        enable_cross_compile_for_windows=True,
         **kwargs,
     )
     logger.info("successfully compiled and saved the module for windows")

py/torch_tensorrt/dynamo/_compiler.py

@@ -75,17 +75,18 @@ def cross_compile_save_for_windows(
 
     # TODO: confirm with Naren whether to raise the error or just warning and ignore what user's settings for the following flags
     # disable the following settings which should not be enabled for cross compile for windows
-    keys = (
+    key_sets = {
         "use_python_runtime",
         "make_refittable",
         "lazy_engine_init",
         "cache_built_engines",
         "reuse_cached_engines",
         "custom_engine_cache",
-    )
+    }
     # disable these settings
-    for key in keys:
-        if key in kwargs.keys() and kwargs.get(key):
+    kwarg_key_sets = set(kwargs.keys())
+    for key in key_sets.intersection(kwarg_key_sets):
+        if kwargs.get(key):
             logger.warning(
                 f"arg: {key} should not be enabled for cross compile for windows feature, it is ignored."
             )
@@ -360,6 +361,7 @@ def compile(
         "lazy_engine_init": lazy_engine_init,
         "cache_built_engines": cache_built_engines,
         "reuse_cached_engines": reuse_cached_engines,
+        "enable_cross_compile_for_windows": enable_cross_compile_for_windows,
     }
 
     settings = CompilationSettings(**compilation_options)
@@ -547,7 +549,6 @@ def contains_metadata(gm: torch.fx.GraphModule) -> bool:
             )
 
             trt_modules[name] = trt_module
-            print(f"lan added {name=}, {trt_module.output_shapes=}")
 
     # Parse the graph I/O and store it in dryrun tracker
     parse_graph_io(gm, dryrun_tracker)

py/torch_tensorrt/dynamo/utils.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 import logging
-import platform
 from dataclasses import fields, replace
 from enum import Enum
 from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple, Union
@@ -662,32 +661,3 @@ def get_flat_args_with_check(
     flat_args_with_path, received_spec = pytree.tree_flatten_with_path((args, kwargs))
     flat_args = tuple(x[1] for x in flat_args_with_path)
     return flat_args, received_spec
-
-
-def validate_cross_compile_for_windows_settings(file_path: str, **kwargs: Any) -> Any:
-    if platform.system() != "Linux" or platform.architecture()[0] != "64bit":
-        raise RuntimeError(
-            f"Cross compile for windows is only supported on AMD 64bit Linux architecture, current platform: {platform.system()=}, {platform.architecture()[0]=}"
-        )
-
-    if not file_path:
-        raise ValueError("File path cannot be empty. Please provide a valid file path")
-
-    # TODO: confirm with Naren whether to raise the error or just warning and ignore what user's settings for the following flags
-    keys = (
-        "use_python_runtime",
-        "make_refittable",
-        "lazy_engine_init",
-        "cache_built_engines",
-        "reuse_cached_engines",
-        "custom_engine_cache",
-    )
-    # if "use_python_runtime" in kwargs.keys() and kwargs.get("use_python_runtime"):
-    #     raise RuntimeError(
-    #         "cross_compile_save_for_windows() requires use_python_runtime arg to be set as False"
-    #     )
-    # disable these settings
-    for key in keys:
-        if key in kwargs.keys():
-            kwargs[key] = False
-    return kwargs

tests/py/dynamo/runtime/test_000_cross_compile_for_windows.py

@@ -62,7 +62,7 @@ def forward(self, a, b):
     def test_load_from_windows(self):
         trt_ep_path = "tests/py/dynamo/runtime/test_data/trt.ep"
         try:
-            loaded_trt_module = torch.export.load(file_path=trt_ep_path)
+            loaded_trt_module = torch.export.load(trt_ep_path)
             trt_gm = loaded_trt_module.module()
             a = torch.randn(2, 3).cuda()
             b = torch.randn(2, 3).cuda()