-
Notifications
You must be signed in to change notification settings - Fork 368
feat: support cumsum dynamo converter #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor comments, otherwise looks good!
|
Thanks for the comments! They have been fixed! |
48feb0c to
8373eb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Please rebase once #2418 is merged, and then ensure this PR also passes all of CI.
8373eb1 to
941b04a
Compare
|
Got errors: Can we merge it now? or waiting for a fix to this bug? |
|
I think it can be merged while that fix is in progress, since it passes all of the newly added tests in CI and none of those models would invoke this specific converter. |
Description
Support
cumsumdynamo converter. This is a part ofsliceconverter.Fixes part of #2215
Type of change
Checklist: