Skip to content

fix: Add test suite for torch.compile backend #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix: Add test suite for torch.compile backend #1849

merged 1 commit into from
Apr 26, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Add tests for Lowering and Partitioning phases of compilation
  • Add utilities for testing, including a custom testing backend which returns intermediate graphs
  • Fix bug in compilation utilities
  • Update CI test suite to include new tests

Fixes #1822

Type of change

  • Testing
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive requested a review from peri044 April 21, 2023 16:28
@gs-olive gs-olive self-assigned this Apr 21, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Apr 21, 2023
@github-actions github-actions bot requested a review from narendasan April 21, 2023 16:29
@gs-olive
fix: Add test suite for torch.compile backend
d6e36be 
- Add tests for Lowering and Partitioning phases of compilation
- Add utilities for testing, including a custom testing backend which
returns intermediate graphs
- Fix bug in compilation utilities
- Update CI test suite to include new tests
@Christina-Young-NVIDIA Christina-Young-NVIDIA added the release: v1.4 Tagged to be included in v1.4 label Apr 24, 2023
narendasan
narendasan approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 7b67780 into pytorch:dynamo_changes Apr 26, 2023
gs-olive added a commit that referenced this pull request Apr 28, 2023
@gs-olive
fix: Add test suite for torch.compile backend (#1849)
fb41cf7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@peri044 peri044 Awaiting requested review from peri044

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API release: v1.4 Tagged to be included in v1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gs-olive @narendasan @facebook-github-bot @Christina-Young-NVIDIA