mnist example update to new compile stage API #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See error here: https://www.internalfb.com/phabricator/paste/view/P782391812 |
|
See new error here: https://www.internalfb.com/phabricator/paste/view/P784276221 |
eddogola
force-pushed
the
update-examples
branch
2 times, most recently
from
ab5ba4f to
147c415
Compare
|
I'm currently saving the ckpts for each epoch in its own directory s.t. if were saving for every 500 epochs, there is a dir under "checkpoints"(or whatever other string that may be set as the checkpoint_dir) called 500, another 1000, and so on. What do you think of this design choice? |
|
Could you double check the files changed to make sure that the change is reflected correctly? |
eddogola
force-pushed
the
update-examples
branch
from
a6a2b24 to
0115743
Compare
with compile_stage one
eddogola
force-pushed
the
update-examples
branch
from
0115743 to
a6ddbe6
Compare
eddogola
added a commit
to eddogola/PiPPy
that referenced
this pull request
Jul 25, 2023
## Description Update the mnist example to use the new compile_stage api ## Checklist: - [x] Has code been commented, particularly in hard-to-understand areas? --------- Co-authored-by: Eddy <ogolaedd@meta.com> Co-authored-by: Eddy Ogola Onyango <ogolaedd@fb.com>
moonbucks
pushed a commit
to moonbucks/PiPPy
that referenced
this pull request
Aug 1, 2023
## Description Update the mnist example to use the new compile_stage api ## Checklist: - [x] Has code been commented, particularly in hard-to-understand areas? --------- Co-authored-by: Eddy <ogolaedd@meta.com> Co-authored-by: Eddy Ogola Onyango <ogolaedd@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the mnist example to use the new compile_stage api
Checklist: