Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe.from_traced - workaround for custom tracers #42

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Pipe.from_traced - workaround for custom tracers #42

merged 1 commit into from
Feb 22, 2022

Conversation

pbelevich
Copy link
Contributor

This is a workaround(and possible a prerequisite) for custom tracers. It will unblock experiments with HF models.

@pbelevich pbelevich requested a review from jamesr66a February 22, 2022 02:58
jamesr66a
jamesr66a reviewed Feb 22, 2022
View reviewed changes
Copy link
Contributor

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this working around? Seems like a refactor but i'm not 100% sure what the issue that this is working around is

@pbelevich
Copy link
Contributor Author

What is this working around? Seems like a refactor but i'm not 100% sure what the issue that this is working around is

I used it in https://github.com/jamesr66a/PiPPy/pull/43

@pbelevich pbelevich requested a review from jamesr66a February 22, 2022 19:02
@pbelevich pbelevich merged commit f0d4cd4 into main Feb 22, 2022
@jamesr66a jamesr66a deleted the pipe_from_traced branch May 13, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesr66a jamesr66a jamesr66a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbelevich @jamesr66a