Make IR private #1099
Merged
Make IR private #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Huang
approved these changes
May 2, 2024
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| import torch | |||
| import torch.distributed as dist | |||
| from pippy.IR import pipe_split | |||
| from pippy._IR import pipe_split | |||
|
fine with me. although, depending on if we care about tip of PipPy breaking we could just do the rename in the pytorch side. i dont think this matters though. once we land it then there is no point of keeping PipPy repo/pkg maintained |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-facing APIs in IR.py have been lifted into
__init__.py. Thus it seems to make sense to make IR.py private.