Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test interleaved schedules #1078

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Test interleaved schedules #1078

merged 3 commits into from
Apr 22, 2024

Conversation

kwen2501
Copy link
Contributor

Description

  • Added test_interleave.py
  • Added to GPU CI.

Status

  • LoopBFS passes the test.
  • Interleaved 1F1B fails with key error re micro-chunk id. (See CI result)

Cc: @H-Huang

parser.add_argument(
"--chunks",
type=int,
default=4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a fix to support this: #1081

Copy link
Member

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

@kwen2501 kwen2501 merged commit 0f1e127 into main Apr 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants