Refactor loss logic in schedules #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2024
Merged
H-Huang
added a commit
that referenced
this pull request
Apr 16, 2024
ghstack-source-id: a23205ba31b924f554386e205beeeb43a42fd112 Pull Request resolved: #1060
H-Huang
added a commit
that referenced
this pull request
Apr 16, 2024
ghstack-source-id: 99b7849be7f347e53dc018ed95f945c409034788 Pull Request resolved: #1060
H-Huang
added a commit
that referenced
this pull request
Apr 16, 2024
ghstack-source-id: 43350a228088048bf98b43c93355912762060559 Pull Request resolved: #1060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the logic used to calculate and update loss into the base
PipelineScheduleclass methods.Will update Interleaved1F1B in the following PR
Stack from ghstack (oldest at bottom):