Add FP32 support for routing_score dtype #4352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D76679848 |
|
This pull request was exported from Phabricator. Differential Revision: D76679848 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Jun 15, 2025
Summary: Pull Request resolved: pytorch#4352 X-link: facebookresearch/FBGEMM#1420 This diff adds support for both bfloat16 and float data types for the routing_score tensor in the index_shuffling_torch function. Previously, the function only supported bfloat16. * Updated the type check to accept both bfloat16 and float data types * Simplified the kernel selection using the DISPATCH_CASE_FLOATING_TYPES macro Differential Revision: D76679848
jianyuh
force-pushed
the
export-D76679848
branch
from
72a38ec to
b9d3802
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76679848 |
jianyuh
force-pushed
the
export-D76679848
branch
from
b9d3802 to
7e88ea4
Compare
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Jun 15, 2025
Summary: Pull Request resolved: pytorch#4352 X-link: facebookresearch/FBGEMM#1420 This diff adds support for both bfloat16 and float data types for the routing_score tensor in the index_shuffling_torch function. Previously, the function only supported bfloat16. * Updated the type check to accept both bfloat16 and float data types * Simplified the kernel selection using the DISPATCH_CASE_FLOATING_TYPES macro Differential Revision: D76679848
|
This pull request was exported from Phabricator. Differential Revision: D76679848 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Jun 15, 2025
Summary: Pull Request resolved: pytorch#4352 X-link: facebookresearch/FBGEMM#1420 This diff adds support for both bfloat16 and float data types for the routing_score tensor in the index_shuffling_torch function. Previously, the function only supported bfloat16. * Updated the type check to accept both bfloat16 and float data types * Simplified the kernel selection using the DISPATCH_CASE_FLOATING_TYPES macro Differential Revision: D76679848
jianyuh
force-pushed
the
export-D76679848
branch
from
7e88ea4 to
8fc603a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76679848 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Jun 15, 2025
Summary: Pull Request resolved: pytorch#4352 X-link: facebookresearch/FBGEMM#1420 This diff adds support for both bfloat16 and float data types for the routing_score tensor in the index_shuffling_torch function. Previously, the function only supported bfloat16. * Updated the type check to accept both bfloat16 and float data types * Simplified the kernel selection using the DISPATCH_CASE_FLOATING_TYPES macro Reviewed By: q10 Differential Revision: D76679848
jianyuh
force-pushed
the
export-D76679848
branch
from
8fc603a to
15a62cb
Compare
Summary: Pull Request resolved: pytorch#4352 X-link: facebookresearch/FBGEMM#1420 This diff adds support for both bfloat16 and float data types for the routing_score tensor in the index_shuffling_torch function. Previously, the function only supported bfloat16. * Updated the type check to accept both bfloat16 and float data types * Simplified the kernel selection using the DISPATCH_CASE_FLOATING_TYPES macro Reviewed By: q10 Differential Revision: D76679848
|
This pull request was exported from Phabricator. Differential Revision: D76679848 |
jianyuh
force-pushed
the
export-D76679848
branch
from
15a62cb to
34e7cc4
Compare
|
This pull request has been merged in 8a01350. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1420
This diff adds support for both bfloat16 and float data types for the routing_score tensor in the index_shuffling_torch function. Previously, the function only supported bfloat16.
Differential Revision: D76679848