Skip to content

Back out "Replace LR access with wrapper" #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spcyppt
Copy link
Contributor

@spcyppt spcyppt commented Mar 20, 2025

Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/949

Original commit changeset: e175eecac4c5

Original Phabricator Diff: D71444136

Reviewed By: sryap

Differential Revision: D71578251

Summary:
X-link: facebookresearch/FBGEMM#949

Original commit changeset: e175eecac4c5

Original Phabricator Diff: D71444136

Reviewed By: sryap

Differential Revision: D71578251
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71578251

spcyppt added a commit to spcyppt/torchrec that referenced this pull request Mar 20, 2025
Summary:
X-link: pytorch/FBGEMM#3857

X-link: facebookresearch/FBGEMM#949

Original commit changeset: e175eecac4c5

Original Phabricator Diff: D71444136

Reviewed By: sryap

Differential Revision: D71578251
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 73ad34a
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67dc87df64eb760008f1011c
😎 Deploy Preview https://deploy-preview-3857--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

Hi @spcyppt!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants