Skip to content

Fix the sync point caused by iter_cpu.item() #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sryap
Copy link
Contributor

@sryap sryap commented Nov 21, 2024

Summary:
Although self.iter_cpu is created on CPU. It might be transferred to
GPU by the user. So, we need to transfer it to CPU explicitly. This
should be done only once.

Differential Revision: D66311970

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66311970

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit cf781d4
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/673fa7552437cb00087f74cf
😎 Deploy Preview https://deploy-preview-3401--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Summary:

X-link: facebookresearch/FBGEMM#489

Although `self.iter_cpu` is created on CPU. It might be transferred to
GPU by the user. So, we need to transfer it to CPU explicitly. This
should be done only once.

Differential Revision: D66311970
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66311970

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b45ae86.

q10 pushed a commit to q10/FBGEMM that referenced this pull request Apr 10, 2025
Summary:
X-link: pytorch#3401

Pull Request resolved: facebookresearch/FBGEMM#489

Although `self.iter_cpu` is created on CPU. It might be transferred to
GPU by the user. So, we need to transfer it to CPU explicitly. This
should be done only once.

Reviewed By: csmiler

Differential Revision: D66311970

fbshipit-source-id: 4ced9b28f2e6c69fc12ccdc7e88404caf8276627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants