Skip to content

Remove unused-variable in some generated code #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Nov 5, 2024

Summary:
LLVM-15 has a warning -Wunused-variable which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with [[maybe_unused]].

#buildsonlynotests - Builds are sufficient

  • If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: sryap

Differential Revision: D65449535

Summary:
LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`.

#buildsonlynotests - Builds are sufficient

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: sryap

Differential Revision: D65449535
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65449535

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 411dd4c
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/672a2715c673060008e26456
😎 Deploy Preview https://deploy-preview-3327--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5a7b494.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 76fe51b.

q10 pushed a commit to q10/FBGEMM that referenced this pull request Apr 10, 2025
Summary:
Pull Request resolved: facebookresearch/FBGEMM#421

X-link: pytorch#3327

LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`.

#buildsonlynotests - Builds are sufficient

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: sryap

Differential Revision: D65449535

fbshipit-source-id: cda295d570f1141d0ffe022e1d5bade8c6bba1e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants