int8 output for seq embeddings #2316
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D53449813 |
YazhiGao
pushed a commit
to YazhiGao/FBGEMM
that referenced
this pull request
Feb 6, 2024
Summary: * int8 output dtype is a gap for recently fbgemm usage case, setup a reasonable refimplementation first, memcpy based. * for sequence embedding, we first unblock dispatch via simple memcpy, it is a pure bw op(no dequant) so memcpy should be reasonably ok. further optimization like ILP via unrolling, try avx non-temp instruction, rep instruction to be done in future iterations. Differential Revision: D53449813
YazhiGao
force-pushed
the
export-D53449813
branch
from
2d86f0d to
5b5027b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53449813 |
YazhiGao
pushed a commit
to YazhiGao/FBGEMM
that referenced
this pull request
Feb 6, 2024
Summary: * int8 output dtype is a gap for recently fbgemm usage case, setup a reasonable refimplementation first, memcpy based. * for sequence embedding, we first unblock dispatch via simple memcpy, it is a pure bw op(no dequant) so memcpy should be reasonably ok. further optimization like ILP via unrolling, try avx non-temp instruction, rep instruction to be done in future iterations. Differential Revision: D53449813
YazhiGao
force-pushed
the
export-D53449813
branch
from
5b5027b to
89445b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53449813 |
YazhiGao
pushed a commit
to YazhiGao/FBGEMM
that referenced
this pull request
Feb 6, 2024
Summary: * int8 output dtype is a gap for recently fbgemm usage case, setup a reasonable refimplementation first, memcpy based. * for sequence embedding, we first unblock dispatch via simple memcpy, it is a pure bw op(no dequant) so memcpy should be reasonably ok. further optimization like ILP via unrolling, try avx non-temp instruction, rep instruction to be done in future iterations. Differential Revision: D53449813
YazhiGao
force-pushed
the
export-D53449813
branch
from
89445b1 to
ea763e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53449813 |
Summary: * int8 output dtype is a gap for recently fbgemm usage case, setup a reasonable refimplementation first, memcpy based. * for sequence embedding, we first unblock dispatch via simple memcpy, it is a pure bw op(no dequant) so memcpy should be reasonably ok. further optimization like ILP via unrolling, try avx non-temp instruction, rep instruction to be done in future iterations. Differential Revision: D53449813
YazhiGao
force-pushed
the
export-D53449813
branch
from
ea763e9 to
816faa1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53449813 |
|
This pull request has been merged in af41af1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D53449813