Enable subwarp only for unweighted #2051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49159119 |
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D49159119 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Oct 9, 2023
Summary: Pull Request resolved: pytorch#2051 Disable the subwarp optimization for weighted TBE - The cause of the NE issue has to be investigated. - This does not affect the overall E2E performance much since the majority of TBEs in the model is unweighted Reviewed By: jasonjk-park Differential Revision: D49159119 fbshipit-source-id: a70c2fc8a55aaa4e04e8285b20d9dd8ab7069ed5
sryap
force-pushed
the
export-D49159119
branch
from
7a0d501 to
b096627
Compare
Differential Revision: D49605180 fbshipit-source-id: de1824908ba741e4c631e91b69a0e17c740d040e
Summary: Pull Request resolved: pytorch#2051 Disable the subwarp optimization for weighted TBE - The cause of the NE issue has to be investigated. - This does not affect the overall E2E performance much since the majority of TBEs in the model is unweighted Reviewed By: jasonjk-park Differential Revision: D49159119 fbshipit-source-id: 545b8428e228c77b8ef03c41f203384710519eb7
|
This pull request was exported from Phabricator. Differential Revision: D49159119 |
sryap
force-pushed
the
export-D49159119
branch
from
b096627 to
f30ac93
Compare
|
This pull request has been merged in 85a91d5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Disable the subwarp optimization for weighted TBE
majority of TBEs in the model is unweighted
Differential Revision: D49159119