Skip to content

Fix OSS macos CI error on the trunk #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jianyuh
Copy link
Member

@jianyuh jianyuh commented Jun 19, 2023

Summary:
Fix some trunk issues on OSS FBGEMM macos tests:

https://github.com/pytorch/FBGEMM/actions/runs/5306099684/jobs/9604231400

/Users/runner/work/FBGEMM/FBGEMM/src/RefImplementations.cc:1421:10: error: unused parameter 'is_bf16_out' [-Werror,-Wunused-parameter]
    bool is_bf16_out) {
         ^
1 error generated.

It should come from D46789900. cc excelle08 sryap

Differential Revision: D46832373

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for pytorch-fbgemm-docs canceled.

Name Link
🔨 Latest commit c1d7a7a
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6490d8b2b4d6e00008b0b80c

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46832373

jianyuh added a commit to jianyuh/FBGEMM that referenced this pull request Jun 19, 2023
Summary:
Pull Request resolved: pytorch#1836

Fix some trunk issues on OSS FBGEMM macos tests:

https://github.com/pytorch/FBGEMM/actions/runs/5306099684/jobs/9604231400

```
/Users/runner/work/FBGEMM/FBGEMM/src/RefImplementations.cc:1421:10: error: unused parameter 'is_bf16_out' [-Werror,-Wunused-parameter]
    bool is_bf16_out) {
         ^
1 error generated.
```

It should come from D46789900. cc excelle08 sryap

Differential Revision: D46832373

fbshipit-source-id: dd8c178c87a77f4eeeb64d27abe02a2978633972
@jianyuh jianyuh force-pushed the export-D46832373 branch from a923bf6 to 983588d Compare June 19, 2023 05:35
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46832373

jianyuh added a commit to jianyuh/FBGEMM that referenced this pull request Jun 19, 2023
Summary:
Pull Request resolved: pytorch#1836

Fix some trunk issues on OSS FBGEMM macos tests:

https://github.com/pytorch/FBGEMM/actions/runs/5306099684/jobs/9604231400

```
/Users/runner/work/FBGEMM/FBGEMM/src/RefImplementations.cc:1421:10: error: unused parameter 'is_bf16_out' [-Werror,-Wunused-parameter]
    bool is_bf16_out) {
         ^
1 error generated.
```

It should come from D46789900. cc excelle08 sryap

Differential Revision: D46832373

fbshipit-source-id: fd4d54d26bfbd79ead014aeafed2def54286c721
@jianyuh jianyuh force-pushed the export-D46832373 branch from 983588d to 6906328 Compare June 19, 2023 06:09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46832373

Summary:
Pull Request resolved: pytorch#1836

Fix some trunk issues on OSS FBGEMM macos tests:

https://github.com/pytorch/FBGEMM/actions/runs/5306099684/jobs/9604231400

```
/Users/runner/work/FBGEMM/FBGEMM/src/RefImplementations.cc:1421:10: error: unused parameter 'is_bf16_out' [-Werror,-Wunused-parameter]
    bool is_bf16_out) {
         ^
1 error generated.
```

It should come from D46789900. cc excelle08 sryap

Reviewed By: jspark1105

Differential Revision: D46832373

fbshipit-source-id: f560867711f8979dc69a3057ae70d1d96aad763d
@jianyuh jianyuh force-pushed the export-D46832373 branch from 6906328 to c1d7a7a Compare June 19, 2023 22:37
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46832373

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 22eebba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants