Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring unpack weight function #103

Closed
wants to merge 1 commit into from

Conversation

jianyuh
Copy link
Member

@jianyuh jianyuh commented Jul 10, 2019

Summary:
In the same spirit of D16085552, we do the following in this Diff:

  • Refactor the pack/unpack code for PackB: use the same pack_unpack_ function for both pack and unpack function.
  • Add a unit test.

Reviewed By: dskhudia

Differential Revision: D16160767

Summary:
In the same spirit of D16085552, we do the following in this Diff:
- Refactor the pack/unpack code for PackB: use the same ```pack_unpack_``` function for both ```pack``` and ```unpack``` function.
- Add a unit test.

Reviewed By: dskhudia

Differential Revision: D16160767

fbshipit-source-id: 800482b652c7010ff60506df7f2032ce7c8bc152
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f080393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants