Introduce .bin.ndjson format #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Added support for reading compressed input files in extract_source_mappings.py using gzip. - Updated file handling logic to differentiate between compressed (.bin.ndjson) and uncompressed files. - Enhanced structured_logging.py to enable gzip compression for trace logs, allowing for efficient storage and retrieval. - Modified TritonTraceHandler to handle gzip compression for individual log records, ensuring compatibility with standard gzip readers.
facebook-github-bot
added
the
CLA Signed
FindHao
changed the title
Summary: - Introduced a new script, decompress_bin_ndjson.py, to handle the decompression of .bin.ndjson files back to standard .ndjson format. - The script validates input files, manages output file naming, and provides detailed output on the decompression process, including file sizes and compression ratios. - It utilizes gzip for reading compressed files and includes error handling for various potential issues during decompression.
|
@FindHao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
New .bin.ndjson format summary:
For compression, gzip is fast, reasonably effective, and natively supported in Python. For example, a 950MB raw log file can be compressed to 117MB with gzip and 110MB with lzma. However, gzip is more than 10 times faster than lzma.
Test Plan:
By default, a new trace file generated
./logs/dedicated_log_triton_trace_yhao24_.bin.ndjson. The trace file size is reduced from 24K to 5.3K. In another larger scale experiment, the trace file is reduced from 950M to 117MB.