Skip to content

Add a rule for use_reentrant with checkpoint #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Dec 20, 2023

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2023
@kit1980 kit1980 requested a review from soulitzer December 20, 2023 22:47
@kit1980 kit1980 marked this pull request as ready for review December 20, 2023 22:51
@kit1980 kit1980 requested a review from malfet December 20, 2023 23:09
@malfet
Copy link
Contributor

malfet commented Dec 26, 2023

Looks good to me, though I wonder if there is a way to write abstract CheckDefaultArg class and re-use it for few of the checks

@kit1980
Copy link
Contributor Author

kit1980 commented Dec 26, 2023

Looks good to me, though I wonder if there is a way to write abstract CheckDefaultArg class and re-use it for few of the checks

Thanks, I'll try to refactor later.

@kit1980 kit1980 merged commit 03ea18c into main Dec 26, 2023
@kit1980 kit1980 deleted the sdym/use_reentrant branch December 28, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants