Add autotuning for range() unrolling #219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oulgen
added a commit
that referenced
this pull request
Jun 24, 2025
stack-info: PR: #219, branch: oulgen/stack/14
facebook-github-bot
added
the
CLA Signed
stack-info: PR: #219, branch: oulgen/stack/14
jansel
requested changes
Jun 25, 2025
There was a problem hiding this comment.
Should we be doing it his way or mapping to the unroll flags in upstream Triton?
The upstream unroller can unroll dynamic loops a given number of times. I was thinking maybe the unroll config should be:
unroll_loops : list[int]
where we have one value per loop and can let the autotuner decide how many times to unroll.
| @@ -529,6 +529,8 @@ def visit_For(self, node: ast.For) -> None: | |||
| ) | |||
| outputs: LiftTensorArgs | None = None | |||
| begin, end = self._extract_tile_begin_end(node) | |||
| if (begin is None or isinstance(begin, int)) and isinstance(end, int): | |||
There was a problem hiding this comment.
Is this coming from a Triton requirement? Couldn't re unroll dynamic loops too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Add autotuning for range() unrolling