Fix visitCall in deviceIR. Always visit argument nodes #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
jansel
approved these changes
Jun 14, 2025
|
@joydddd I don't believe ghstack works in this repo. @oulgen can confirm. I have been using https://github.com/modular/stack-pr instead. You may need to recreate the PR using that. |
there's a way to make ghstack work, but its pretty tedious, so yea please use stack-pr, it is very similar |
jansel
reviewed
Jun 15, 2025
Comment on lines
423
to
425
| def _to_proxy(self, node: ast.AST) -> object: | ||
| assert isinstance(node, ExtendedAST) | ||
| type_info = node._type_info | ||
| if not type_info.contains_tensor(): | ||
| return type_info.proxy() | ||
| return self.visit(node) |
There was a problem hiding this comment.
This function has become the same as self.visit. Let's delete it and update the callers to call self.visit directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):