This repository was archived by the owner on Aug 7, 2024. It is now read-only.
add numerical test for FSDP #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds a test for numerical equivalence of single GPU vs FSDP for a toy model. Note: this is not related to fp8 yet, a future PR will add a test that this still holds for fp8. Test Plan: ``` ./float8_playground/test_fsdp.sh ``` Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
awgu
reviewed
Aug 2, 2023
|
|
||
| model = get_model(K, N).to(rank) | ||
| model.load_state_dict(torch.load(sd_in_fname)) | ||
| model = FSDP(model) |
There was a problem hiding this comment.
For more realistic models, we should use nested FSDP wrapping to be representative of a real workload. This can be achieved by passing an auto_wrap_policy argument. Feel free to message me if you have a particular model and need some clarification on how to pass a good auto_wrap_policy.
There was a problem hiding this comment.
cool, thanks!
yep, that will come later, this is just a super simple test to iron out easy to catch issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a test for numerical equivalence of single GPU vs FSDP for a toy model.
Note: this is not related to fp8 yet, a future PR will add a test that this still holds for fp8.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: