Skip to content

Conversation

@altendky
Copy link
Collaborator

No description provided.

@altendky altendky marked this pull request as ready for review October 21, 2022 23:53
@altendky
Copy link
Collaborator Author

So, do you want to drop 3.7? Only check the safety in 3.10? Or...

@altendky altendky marked this pull request as draft October 21, 2022 23:54
@fabianp
Copy link
Collaborator

fabianp commented Nov 1, 2022

yeah, I'm happy to drop 3.7

@altendky
Copy link
Collaborator Author

altendky commented Nov 1, 2022

kick ci

@altendky altendky closed this Nov 1, 2022
@altendky altendky reopened this Nov 1, 2022
@altendky
Copy link
Collaborator Author

altendky commented Nov 1, 2022

Not beautiful, but a first pass from which there can be refinement anyways. Checks are run on 3.10 as I usually use one version behind the latest release for this. The point is to run the checks, not check if they have bugs on the latest Python version. The tests are run on all supported Python versions, 3.7 through 3.11. I left safety running on everything except 3.7 right now.

I'm good with this going in as is, if you are ok with it. If we find stuff to tweak we can do it piece by piece. Let me know what you think.

@altendky altendky marked this pull request as ready for review November 1, 2022 18:50
@fabianp
Copy link
Collaborator

fabianp commented Nov 2, 2022

thanks! LGTM

@fabianp fabianp merged commit dd9ed70 into pythonprofilers:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants