Skip to content

feat : navigation UX 개선 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
earthyoung merged 2 commits into from
Aug 8, 2025
Merged

feat : navigation UX 개선 #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d400f5e
feat : children이 한 개인 경우 중 hide가 true면 화살표 안생기도록 수정
y00eunji Aug 4, 2025
d267f09
feat: 모바일 내비게이션에서 자식 메뉴가 있는 경우 버튼으로 변경
y00eunji Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions apps/pyconkr/src/components/layout/Header/Mobile/MobileNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,16 @@ export const MobileNavigation: React.FC<MobileNavigationProps> = ({ isOpen, onCl
.filter((s) => !s.hide)
.map((menu) => (
<MenuItem isMainPath={isMainPath} key={menu.id}>
<MenuLink isMainPath={isMainPath} to={menu.route_code} onClick={handleClose}>
{menu.name}
</MenuLink>
{!R.isEmpty(menu.children) && (
{!R.isEmpty(menu.children) && Object.values(menu.children).some((child) => !child.hide) ? (
<MenuButton isMainPath={isMainPath} onClick={() => navigateToDepth2(menu)}>
{menu.name}
</MenuButton>
) : (
<MenuLink isMainPath={isMainPath} to={menu.route_code} onClick={handleClose}>
{menu.name}
</MenuLink>
)}
{!R.isEmpty(menu.children) && Object.values(menu.children).some((child) => !child.hide) && (
<MenuArrowButton isMainPath={isMainPath} onClick={() => navigateToDepth2(menu)}>
<ArrowForward fontSize="small" />
</MenuArrowButton>
Expand Down Expand Up @@ -123,7 +129,7 @@ export const MobileNavigation: React.FC<MobileNavigationProps> = ({ isOpen, onCl
<Link to={`${navState.depth1!.route_code}/${menu.route_code}`} onClick={handleClose} style={{ textDecoration: "none" }}>
<MenuChip isMainPath={isMainPath} label={menu.name} clickable />
</Link>
{!R.isEmpty(menu.children) && (
{!R.isEmpty(menu.children) && Object.values(menu.children).some((child) => !child.hide) && (
<MenuArrowButton isMainPath={isMainPath} onClick={() => navigateToDepth3(menu)}>
<ArrowForward fontSize="small" />
</MenuArrowButton>
Expand Down Expand Up @@ -250,6 +256,17 @@ const MenuLink = styled(Link)<{ isMainPath?: boolean }>(({ theme, isMainPath = t
fontWeight: 600,
}));

const MenuButton = styled(Button)<{ isMainPath?: boolean }>(({ theme, isMainPath = true }) => ({
color: isMainPath ? theme.palette.mobileNavigation.main.text : theme.palette.mobileNavigation.sub.text,
textTransform: "none",
fontSize: "20px",
fontWeight: 600,
padding: 0,
minWidth: "auto",
minHeight: "auto",
justifyContent: "flex-start",
}));

const MenuArrowButton = styled(IconButton)<{ isMainPath?: boolean }>(({ theme, isMainPath = true }) => ({
color: isMainPath ? theme.palette.mobileNavigation.main.text : theme.palette.mobileNavigation.sub.text,
padding: 8,
Expand Down