Skip to content

Remove schedule event search type patch - #4779

Merged
patrick91 merged 1 commit into
codex/test-search-events-for-schedule-queryfrom
codex/remove-search-event-type-patch
Aug 15, 2026
Merged

Remove schedule event search type patch#4779
patrick91 merged 1 commit into
codex/test-search-events-for-schedule-queryfrom
codex/remove-search-event-type-patch

Conversation

@patrick91

@patrick91 patrick91 commented Aug 14, 2026

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Aug 14, 2026 8:17pm

@claude

claude Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary: Removes a manual __strawberry_definition__ monkey-patch that was forcing GraphQL union-type resolution for Submission results in search_events_for_schedule.

  • The removed loop was overriding proposal.__strawberry_definition__ on each SubmissionModel instance, presumably to make strawberry_django resolve it correctly as Submission in the Submission | Keynote union. Since there's only one strawberry_django.type wrapping models.Submission, strawberry_django's default isinstance-based union resolution should handle this on its own, so the removal is plausible — but this is exactly the code path that test_search in backend/api/schedule/tests/test_search_events_for_schedule.py asserts on (it checks __typename: "Submission" for these results). Since the patch being removed was presumably added for a reason, please confirm that test (and test_frontend_search_events_query) is green in CI before merging, since a local run wasn't possible here.

No other issues found.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.85%. Comparing base (e20ec16) to head (9c5c035).

Additional details and impacted files
@@                               Coverage Diff                               @@
##           codex/test-search-events-for-schedule-query    #4779      +/-   ##
===============================================================================
- Coverage                                        92.86%   92.85%   -0.01%     
===============================================================================
  Files                                              360      360              
  Lines                                            11163    11161       -2     
  Branches                                           894      893       -1     
===============================================================================
- Hits                                             10366    10364       -2     
  Misses                                             675      675              
  Partials                                           122      122              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@patrick91
patrick91 merged commit 3695b49 into main Aug 15, 2026
9 checks passed
@patrick91
patrick91 deleted the codex/remove-search-event-type-patch branch August 15, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant