Flexible Grant categories #4420
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the hardcoded grant reimbursement types with a configurable model. Each conference can now define its own reimbursement categories with custom: - Names and descriptions - Maximum amounts per category - Default inclusion settings - Category types (travel, ticket, accommodation, other) This allows for more flexible grant management where each conference can customize their reimbursement options while maintaining data consistency through the category system. It replaces the old hardcoded `ApprovedType` choices with a dynamic model-based approach.
This change introduces a new GrantReimbursement model and related migration to support flexible grant reimbursement categories. The model links grants to their reimbursement categories and stores the granted amount for each. Key changes: - Add `GrantReimbursement` model as through table for M2M relationship - Add `reimbursement_categories` M2M field to `Grant` model - Create migration for the new model and relationship - Add factory for testing This change enables more granular control over grant reimbursements by allowing different categories (e.g., travel, accommodation) with specific amounts for each category.
Add a Django management command to migrate old grant data to the new reimbursement model. This command will: - Create default reimbursement categories for each conference - Convert approved_type and amount fields into GrantReimbursement records - Validate data integrity by comparing totals before and after migration The migration preserves the full history of grant amounts while moving to the new flexible category system.
Update GrantAdmin to show approved reimbursements and total allocated amount. Add utility methods to Grant model for checking reimbursement status. Key changes: - Add column for approved reimbursement categories and amounts - Add inline editor for GrantReimbursement - Add `total_allocated_amount` and `has_approved` helper methods - Optimize queries with select_related and prefetch_related
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4420 +/- ##
==========================================
+ Coverage 94.47% 94.49% +0.01%
==========================================
Files 351 352 +1
Lines 10036 10111 +75
Branches 710 719 +9
==========================================
+ Hits 9482 9554 +72
- Misses 461 463 +2
- Partials 93 94 +1 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ToDo