Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on_delete deprecation warnings + linting improvements #662

Merged
merged 6 commits into from
Apr 5, 2020
Merged

Fix on_delete deprecation warnings + linting improvements #662

merged 6 commits into from
Apr 5, 2020

Conversation

pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Apr 4, 2020

Supercedes and closes #653, by carrying forward some great work done by @sks444.

Also enables linting for all migration files, because it's pretty clear that we should have that.

@pradyunsg pradyunsg changed the title Fix on_delete deprecation warnings and related fixes Fix on_delete deprecation warnings + linting improvements Apr 4, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 67.259% when pulling 4cc2bfd on pradyunsg:pr/653 into cb63800 on pythonindia:master.

@pradyunsg pradyunsg marked this pull request as ready for review April 4, 2020 22:03
@pradyunsg
Copy link
Contributor Author

I'm gonna be a little reckless and merge this, since I don't think there's anything here that's really worth bikeshedding and we can iterate on this if we really need to.

@pradyunsg pradyunsg merged commit 63d428d into pythonindia:master Apr 5, 2020
@pradyunsg pradyunsg deleted the pr/653 branch April 5, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants