-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecations: Round 1 #643
Fix deprecations: Round 1 #643
Conversation
sigh This is gonna take a while. |
@pradyunsg I think it would be a better idea for new contributors to start fixing the deprecation warnings. Through that, they can get started on how junction is structured. Can you create an Umbrella issue with all the warnings? |
What are these warnings? And when are we able to see those ? |
They show up if you run the tests locally. These were a little more involved. There are a few that are from our dependencies (which need to be upgraded) and a whole lot from needing to specify on_deleye behaviors. I welcome someone to help with the second but, as well as to file an umbrella issue. |
@ananyo2012 we can also run @pradyunsg I can help out with the |
1 similar comment
@pradyunsg Are these changes ready ? |
Yup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ship it !
No description provided.