Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations: Round 1 #643

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Fix deprecations: Round 1 #643

merged 4 commits into from
Mar 23, 2020

Conversation

pradyunsg
Copy link
Contributor

No description provided.

@pradyunsg
Copy link
Contributor Author

369 warnings

sigh This is gonna take a while.

@palnabarun
Copy link
Member

@pradyunsg I think it would be a better idea for new contributors to start fixing the deprecation warnings. Through that, they can get started on how junction is structured. Can you create an Umbrella issue with all the warnings?

@ananyo2012
Copy link
Contributor

What are these warnings? And when are we able to see those ?

@pradyunsg
Copy link
Contributor Author

They show up if you run the tests locally.

These were a little more involved. There are a few that are from our dependencies (which need to be upgraded) and a whole lot from needing to specify on_deleye behaviors.

I welcome someone to help with the second but, as well as to file an umbrella issue.

@sks444
Copy link
Contributor

sks444 commented Mar 21, 2020

@ananyo2012 we can also run python -Wall manage.py runserver to see all the deprecated warnings. Removing these will help us in upgrading Django to 2/3.

@pradyunsg I can help out with the on_delete warnings.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 67.163% when pulling 57558bf on pradyunsg:fix-deprecations-round-1 into 87c3172 on pythonindia:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 67.163% when pulling 57558bf on pradyunsg:fix-deprecations-round-1 into 87c3172 on pythonindia:master.

@ananyo2012
Copy link
Contributor

@pradyunsg Are these changes ready ?

@pradyunsg
Copy link
Contributor Author

Yup!

Copy link
Contributor

@ananyo2012 ananyo2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it !

@pradyunsg pradyunsg merged commit 2d9e8bc into pythonindia:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants