Skip to content

Specify attrs minimum required version #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2021

Conversation

albertvaka
Copy link
Contributor

@albertvaka albertvaka commented Jun 8, 2021

We use the argument kw_only in attr.s which was added in 18.2.0 [1]

[1] https://github.com/python-attrs/attrs/blob/main/CHANGELOG.rst#1820-2018-09-01

@albertvaka
Copy link
Contributor Author

Using an older version results in:

Traceback (most recent call last):
  File "/Users/albertvaka/example.py", line 1, in <module>
    import pytiled_parser
  File "/usr/local/lib/python3.9/site-packages/pytiled_parser/__init__.py", line 15, in <module>
    from .layer import ImageLayer, Layer, LayerGroup, ObjectLayer, TileLayer
  File "/usr/local/lib/python3.9/site-packages/pytiled_parser/layer.py", line 23, in <module>
    from . import tiled_object
  File "/usr/local/lib/python3.9/site-packages/pytiled_parser/tiled_object.py", line 13, in <module>
    @attr.s(auto_attribs=True, kw_only=True)
TypeError: attrs() got an unexpected keyword argument 'kw_only'

@Cleptomania
Copy link
Member

Thanks for the fix, will be included in a 1.6.0 release that's probably coming up sometime next week or the week after.

@Cleptomania Cleptomania changed the base branch from master to development June 12, 2021 17:13
@Cleptomania Cleptomania merged commit ee14883 into pythonarcade:development Jun 12, 2021
@albertvaka
Copy link
Contributor Author

There's no rush whatsoever, thanks for your time :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants