Skip to content

gui: Fix UIManager not clearing the surface when label triggered a full render during a render cycle #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025
Merged

gui: Fix UIManager not clearing the surface when label triggered a full render during a render cycle #2552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions arcade/gui/ui_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,9 @@ def _do_layout(self):
def _do_render(self, force=False):
layers = sorted(self.children.keys())
force = force or self._requires_render
# already reset here, so it can be set again in case during rendering a
# widget requests a re-rendering like a UILabel updating its font
self._requires_render = False
for layer in layers:
surface = self._get_surface(layer)

Expand All @@ -267,8 +270,6 @@ def _do_render(self, force=False):
for child in self.children[layer]:
child._do_render(surface, force)

self._requires_render = False

def enable(self) -> None:
"""Registers handler functions (`on_...`) to :py:attr:`arcade.gui.UIElement`

Expand Down
Loading