Point in polygon fix #2336
Merged
Point in polygon fix #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FengchiW
commented
Aug 4, 2024
|
|
||
| # print() |
There was a problem hiding this comment.
Not sure why these comments are here
There was a problem hiding this comment.
Just remove if they don't make sense. It means they have low value.
Arcade.Window.2024-08-04.11-19-38.mp4 |
|
The initial non-detection is because the window is not focused |
einarf
added a commit
that referenced
this pull request
Sep 28, 2024
* split up geometry tests * split up geometry tests * Experimental smoke test tool based on einarf's prototype * Point in polygon fix (#2336) * Fixed get point in poly when getting a horizontal edge * legacy changes * Test cleanup * tests: Point in box with zero width or height * Fix collision code and tests * Include both cc and cw polygons --------- Co-authored-by: Einar Forselv <eforselv@gmail.com> Co-authored-by: Wilson (Fengchi) Wang <wilsonfwang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a separate check to horizontal line segments, this resolves the issues but I'm still digging for why the original implementation fails to validate on this edge case