More cleanup for update_quick_index.py + helpers #2113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move shared member iteration into a generator function * Rename member special rules declarations dict to be general instead of class-specific
* Move NotExcludedBy, get_module_path, and EMPTY_TUPLE into doc_helpers * Update __all__ * Clean up imports
pushfoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Organize doc helpers better and things like missing docstrings
Why?
TL;DR: Maintainability
Changes
util/doc_helpersmoduleget_module_path, etc)VirtualFilepathlib.Pathinside vfs-related classes