Skip to content

Fix SpriteList.pop exception type on empty #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2024
Merged

Fix SpriteList.pop exception type on empty #2103

merged 5 commits into from
Jun 12, 2024

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Jun 10, 2024

  • Use IndexError instead of ValueError as with list
  • Touch up docstring
  • Add test for the exception behavior

@Cleptomania Cleptomania merged commit 8b4ad30 into pythonarcade:development Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pushfoo @Cleptomania