Skip to content

Fix and improve style of arcade.types.Color docstrings #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented May 31, 2024

TL;DR: Style compliance improvements as reference for upcoming Rect doc work

Changes:

  1. Document undocumented properties / attributes which would show up as "Alias for slot 1" or blank
  2. Use .. code-block:: python instead of Examples::
  3. Add .. note:: blocks with alternatives to features we didn't implement
  4. Move summary lines to start of docstrings
  5. Add cross-ref links
  6. Use literal formatting more consistently
  7. Fix various broken formatting

pushfoo and others added 21 commits May 31, 2024 11:40
* Move summary line onto same line as opening triple quotes

* Cross-ref color top-level def
* Move summary line to opening of docstring

* Cross-ref Color

* Rephrase summary line and brightness param explanation
* Fix broken cross-ref

* Move summary line to top of the page

* Rephrase for clarity
* Add cross-refs

* Phrasing improvements
* Use code-block instead of ::

* Cross-ref the summary line

* Put examples first

* Add cross-refs to external doc

* Add error notification

* Sort cross-refs
* Move unpack example to from_iterable

* Move example code up to top

* List creation helpers immediately in order of estimated usage likelihood

* Add cross-references on HSV support via colorsys and colour

* Inset unpack example with advice on when to use it
* Use code-block

* Remove "Examples:"

* Use clear values for the example

* Use "Convert" instead of "Return" in the summary line

* Explain what the decimal integer in the examples is
* Add cross-refs

* Duplicate changes from from_uint32
* Show effects of repeat

* Move summary line to first line of docstring
* s/swizzle_string/order/g

* Add cross-ref to array and structr for people who want to pack data
@Cleptomania Cleptomania merged commit c6d00dd into pythonarcade:development Jun 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants