Skip to content

Camera Touchups for arcade 3.0RC1 #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
May 28, 2024
Merged

Camera Touchups for arcade 3.0RC1 #2094

merged 42 commits into from
May 28, 2024

Conversation

DragonMoffon
Copy link
Collaborator

@DragonMoffon DragonMoffon commented May 26, 2024 •
edited
Loading

Full change list:

  • Added Camera2D to arcade's top level now that its __init__ has been fixed
  • Added generic functions to generate View, and Projection matrices from camera PoDs.
  • Added generic functions to project and unproject coordinates using Matrices
  • Added StaticCamera, which holds view and projection matrices directly for manual/temporary cameras
  • Added Unproject and Project methods to all projectors
  • Added new properties to Camera2D for key points around the visible boundary
  • Added method to Camera2D to quickly test if a point is visible
  • Moved the current and default camera to ArcadeContext so the default camera better behaves with framebuffers, and changing viewports
  • Removed map_screen_to_world_coordinate, use unproject instead.
  • Switching views now resets the active framebuffer to the screen and the active camera to the default
  • Window.viewport now returns the screen's viewport, not the currently active viewport.
  • The render target in Camera2D is now optional
  • Fixed Camera2D activating the render target twice in Camera2D.activate
  • Fixed Camera2D ignoring the viewport when initialising with a RenderTarget
  • Fixed TextureAtlas not using a View matrix when rendering into a texture

DragonMoffon and others added 29 commits April 28, 2024 15:20
@DragonMoffon
Make generic matrix generation methods and make projectors use them
b25cf98
@DragonMoffon
Merge branch 'camera-touchups' of https://github.com/DragonMoffon/arcade
7c7742f 
 into camera-touchups
@DragonMoffon
Correct typing issue in generate_orthographic_matrix
cfa5308
@DragonMoffon
updating unit tests and improving orthographic projector unproject …
8c00ba5 
…method
@DragonMoffon
Add Project and Unproject methods
a6c60fb
@DragonMoffon
linting corrections
f8e42a1
@DragonMoffon
make all Projectors unproject return a 3-tuple
4dd5ce9
@pushfoo
Touchup touchups (#5)
3311f77 
* Add docstrings for Projector, Projector.use, and Project.activate

* Add docstring for Projection Protocol

* Move PerspectiveProjector.activate onto Projector protocol & subclass

* Replace Orthographic Projector's activate with Protocol default implementation
@DragonMoffon
Moving activate back into projectors
ee35a52 
sadly it is harder to make generic than anticipated
@DragonMoffon
Move current_camera and default_camera to the ArcadeContext so …
fc3d038 
…they can be reliably updated when viewport is changed
@DragonMoffon
Typing extensions for the win
6f5b48a
@DragonMoffon
Typing extensions for the win: revengance
57653b8
@DragonMoffon
Linty Linty
189507b
@DragonMoffon
Fixed issue where switching view would not correct viewport or curren…
03e52a0 
…t camera
@DragonMoffon
correcting use of Window.screen
8dced2a
@DragonMoffon
a little fix of doubling up on the render target [Thanks @jans]
f61953a
@DragonMoffon
adding forgetten about methods to arcade.camera.data_types.__all__
bd757cf
@DragonMoffon
Make the render target in Camera2D optional
32a1d0c
@DragonMoffon
continue improvement
3d6b6f3
@DragonMoffon
Adding a static camera and context managers
fe81021
@DragonMoffon
typing correction
8115d63
@DragonMoffon
remove wasteful context manager code and fixing pyright issue
95b323a
@DragonMoffon
remove old context manager
072b2f5
@DragonMoffon
update Texture Atlas to use a static camera
3d8bfbf 
also fix bug in static camera methods
@DragonMoffon
left in print statement
66b2a75
@DragonMoffon
Fix [Camera]: Camera2D uses RenderTarget's viewport if no other is …
2c5341d 
…offered
@DragonMoffon
Feat [Camera]: Make project and unproject method generic
0fcbbd4
@DragonMoffon
Fix [Camera]: update the Projector Protocol which got overridden at s…
18b4a97 
…ome point
@DragonMoffon
Fix [Camera]: Ensured StaticCamera fit the Projector Protocol
54feb7c
@DragonMoffon DragonMoffon changed the title Camera Touchups for arcade 3.0RC Camera Touchups for arcade 3.0RC1 May 26, 2024
@pushfoo
Fix small Sphinx syntax issues in camera docstrings
85b9f83 
* Fix list-table syntax with newlines

* Fix external intersphinx context manager cross-reference
DigiDuncan
DigiDuncan reviewed May 27, 2024
View reviewed changes
Copy link
Collaborator

@DigiDuncan DigiDuncan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dragon in the Discord requested we wait to merge this since they found a bug.

Solved!

@eruvanos eruvanos merged commit 70bb3ac into pythonarcade:development May 28, 2024
8 checks passed
@DragonMoffon DragonMoffon deleted the camera-touchups branch June 10, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigiDuncan DigiDuncan DigiDuncan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DragonMoffon @DigiDuncan @eruvanos @pushfoo