Skip to content

Fix incorrect lrwh function name in arcade.draw_commands #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 27, 2024
Merged

Fix incorrect lrwh function name in arcade.draw_commands #2075

merged 5 commits into from
Apr 27, 2024

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Apr 25, 2024

TL;DR: draw_lrwh_rectangle_textured should be draw_lbwh_rectangle_textured

Changes

  1. Add new draw_lbwh_rectangle_textured function
    1. Add function itself
    2. Add it to local __all__
    3. Update arcade.__all__
  2. Deprecate draw_lrwh_rectangle_textured
  3. Switch usage:
    1. arcade.gui.surface.Surface
    2. Examples
    3. Tests

pushfoo added 5 commits April 25, 2024 18:52
@pushfoo
Add renamed method and mark typo name for removal
d1f4ee5 
* Add new method using xywh naming scheme

* Mark old one for removal

* Add to __all_s
@pushfoo
Swap textured rect lrwh to lbwh in examples
211e2d2 
* Replace arcade. usage in collect coins bg demo

* Add import + replace arcade. usage in experimental light_demo
@pushfoo
Replace arcade lrwh texture call in gui
c06e3c6
@pushfoo
Replace usage in tests
4d83495
@pushfoo
Add deprecation to release notes
3a86a2f
@pushfoo pushfoo changed the title Fix nonsense function name in arcade.draw_commands Fix incorrect lrwh function name in arcade.draw_commands Apr 26, 2024
@Cleptomania Cleptomania merged commit 3b98810 into pythonarcade:development Apr 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pushfoo @Cleptomania