Skip to content

Correct Camera2D Class comments #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

MiCurry
Copy link
Contributor

@MiCurry MiCurry commented Apr 13, 2024

This commit updates the Camera2D Class comments. It incorrectly stated that camera_data held the viewport, but it does not. The viewport is now defined in OrthographicProjectionData.

This commit updates the Camera2D Class comments. They incorrectly stated
that camera_data held the viewport, but it does not. The viewport is now
defined in `OrthographicProjectionData`.
Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: Merge ASAP, changes are small and good. 👍

@Cleptomania Cleptomania merged commit 70058f8 into pythonarcade:development Apr 13, 2024
7 of 8 checks passed
@MiCurry MiCurry deleted the camera_2d_comments branch April 13, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants