Skip to content

Fix non-numeric pyright typing issues caused by pyglet changes #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Fix non-numeric pyright typing issues caused by pyglet changes #2058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccf619a
Ignore Literal-typing on pyglet layouts
pushfoo Apr 9, 2024
d727923
Add noqa to account for pyglet's .pyi being out of date
pushfoo Apr 9, 2024
16dee2e
Add type: ignore for Text's anchor_y
pushfoo Apr 9, 2024
510cc56
Extra-strong ignore since pyright doesn't listen to # noqa on missing…
pushfoo Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion arcade/management/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ def show_info():
print('version:', window.ctx.gl_version)
print('python:', sys.version)
print('platform:', sys.platform)
print('pyglet version:', pyglet.__version__)
# The next line uses noqa because pyglet's .pyi is out of date
print('pyglet version:', pyglet.__version__) # pyright: ignore # noqa
print('PIL version:', PIL.__version__)


Expand Down
4 changes: 2 additions & 2 deletions arcade/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ def anchor_x(self) -> str:

@anchor_x.setter
def anchor_x(self, anchor_x: str):
self._label.anchor_x = anchor_x
self._label.anchor_x = anchor_x # type: ignore

@property
def anchor_y(self) -> str:
Expand All @@ -371,7 +371,7 @@ def anchor_y(self) -> str:

@anchor_y.setter
def anchor_y(self, anchor_y: str):
self._label.anchor_y = anchor_y
self._label.anchor_y = anchor_y # type: ignore

@property
def rotation(self) -> float:
Expand Down
Loading