Speed up Color.random() via bit math #1995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why call
randint()
four time when one time do trick?This PR speeds up
Color.random()
by ~250% in local testing.It uses bitmasking/bitshifting sorryProfiling
Old (current)
39006028 function calls in 12.579 seconds
random.py:235(_randbelow_with_getrandbits)
random.py:284(randrange)
random.py:358(randint)
types.py:108(__new__)
types.py:381(random)
{built-in method __new__ of type object at 0x00007FFB7F5D9480}
{built-in method _operator.index}
{method 'bit_length' of 'int' objects}
{method 'disable' of '_lsprof.Profiler' objects}
{method 'getrandbits' of '_random.Random' objects}
New (PR)
12001096 function calls in 5.101 seconds
filename:lineno(function)
random.py:235(_randbelow_with_getrandbits)
random.py:284(randrange)
random.py:358(randint)
types.py:108(__new__)
types.py:381(random)
{built-in method __new__ of type object at 0x00007FFB7F5D9480}
{built-in method _operator.index}
{method 'bit_length' of 'int' objects}
{method 'disable' of '_lsprof.Profiler' objects}
{method 'getrandbits' of '_random.Random' objects}