-
Notifications
You must be signed in to change notification settings - Fork 343
remove pause #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pause #1993
Conversation
This is super unnecessary and nothing uses it (now). Even before this PR, it was used once. So, I'm counting this as "weird cruft that should be cut in 3.0." If it's a teaching concern, I recommend to teach them to use `time.sleep()`.
I don't mind removing this one, but if it's referenced in teaching material we migh just need to keep it. Outside of that I don't mind removing it. Especially if it's mainly a thing used internally in tests. @pvcraven Any input on this one? |
From what I can tell, the docs don't reference |
TL;DR: We might want to keep the method but rethink what it does
I think we do: https://learn.arcade.academy/en/latest/ The git history shows Paul C's been updating it, but it doesn't seem to reference the method. What we have now
What should we have?Pause behavior in real-time games usually takes the following approach:
How could we support that?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok removing this function.
Removing the top-level function works too. It doesn't stop any of that other implementation from happening later. 👍 |
I really like the idea of an |
Those ideas tie into a larger rework of events / input that we don't have time for rn. This PR comment thread also isn't the place to discuss it imo. We should merge this. |
Today it's |
This is super unnecessary and nothing uses it (now). Even before this PR, it was used once. So, I'm counting this as "weird cruft that should be cut in 3.0." If it's a teaching concern, I recommend to teach them to use
time.sleep()
.Changes
arcade.pause()