Skip to content

Improve SpriteList typing #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Feb 21, 2024
Merged

Improve SpriteList typing #1977

merged 26 commits into from
Feb 21, 2024

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Feb 18, 2024 •
edited
Loading

Addresses the SpriteList portion of #1867.

Changes

  • Add missing return types
  • Many Nones
  • SpriteType TypeVar where appropriate
  • Annotate SpriteList.extend's argument with Iterable[SpriteType] instead of List[SpriteType]
  • Annotate SpriteList.program and many protected attributes as Optional[Program]
  • Remove some extra whitespace

pushfoo added 21 commits February 19, 2024 23:34
@pushfoo
Add missing SpriteType annotations
6523b78
@pushfoo
Add broader Iterable[Texture] annotation for preload_textures
bb4f7af
@pushfoo
Remove extra whitespace after preload_textures
f264611
@pushfoo
Add None return annotation to enable_spatial_hashing
2bbe6a8
@pushfoo
Add None return annotation to SpriteList.sort
4ca78b8
@pushfoo
Add None return annotation to SpriteList.shuffle
1f70625
@pushfoo
Add None return annotation to SpriteList.reverse
e8fe140
@pushfoo
Add None return annotation to SpriteList.insert
3788dec
@pushfoo
Add None return annotation to SpriteList.extend
2e2f7ce
@pushfoo
Add None return annotation to SpriteList.remove
e82259d
@pushfoo
Add None return annotation to SpriteList.swap
b88265b
@pushfoo
Add None return annotation to SpriteList.append
8088775
@pushfoo
Add None return annotation to SpriteList.clear
8d76872
@pushfoo
Add SpriteType return annotation to SpriteList.__getitem__
7a609d0
@pushfoo
Add None return type to internal _update and _*_buffermethods on Spri…
b4e7fe3 
…teList
@pushfoo
Add None return type to on_update and update_animation
2b53670
@pushfoo
Add None return annotation to _recalculate_spatial_hashes
e737f3e
@pushfoo
Revert __getitem__ return annotation for the moment
082e2a9
@pushfoo
Add None return type for SpriteList.__setitem__
b4491fd
@pushfoo
Add None return annotation to SpriteList._init_deferred
d98ef02
@pushfoo
Use @overload typing for SpriteList.__getitem__
64c5ae9
@pushfoo pushfoo force-pushed the sprite_list_type_improvements branch from 2e2b699 to 64c5ae9 Compare February 20, 2024 04:34
@pushfoo pushfoo marked this pull request as ready for review February 20, 2024 05:08
@pushfoo pushfoo requested a review from einarf February 21, 2024 21:06
@einarf
Copy link
Member

einarf commented Feb 21, 2024

Looks good 🚀

@einarf einarf merged commit 4e4c110 into pythonarcade:development Feb 21, 2024
@pushfoo pushfoo deleted the sprite_list_type_improvements branch February 21, 2024 23:34
@pushfoo pushfoo mentioned this pull request Feb 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einarf einarf Awaiting requested review from einarf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pushfoo @einarf