Skip to content

Added the properties for platforms and walls a la ladders #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

FriendlyGecko
Copy link
Contributor

@FriendlyGecko FriendlyGecko commented Feb 16, 2024

This is to give game devs more control of the physics engines.

They can add moving platforms where they didn't exist before or even remove the wall list.

converted platform init check into a one line so that it is in line with the other checks
@FriendlyGecko FriendlyGecko changed the title Added properties platforms and walls a la ladders Added the properties for platforms and walls a la ladders Feb 16, 2024
@FriendlyGecko
Copy link
Contributor Author

This will close issue #1973

BasicSprite type was removed from simple physics engine. Only statement that used it was the engine's wall list init setter statement. Where it limited the spritelist's contents to basic sprites only. Typing.cast was also removed as it seemingly doesn't do anything that explicitly setting the type.
@FriendlyGecko
Copy link
Contributor Author

Stated on discord, but will post it here for clarity. This request is ready for review.

@pvcraven pvcraven merged commit cc987ca into pythonarcade:development Feb 22, 2024
@FriendlyGecko FriendlyGecko deleted the Properties_Physics branch February 22, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants