Improve robustness for line of sight function #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, for the case where the `distance` between the `observer` and `target` is zero the function will crash with a Division by Zero Error. This error can happen if someone designs a chasing enemy that ends up at the players location. I added a check will return True indicating there is line of sight in such a case. Perhaps this should instead be a configurable option? Additionally, the Line of Sight function did not ensure that we have a positive non-zero value for the check resolution. I added a check that will raise a value error in such a case. Also added unit test for the same position for LOS
|
Fixes #1934 |
|
@eruvanos I made a big mistake I was testing whether or position being the same should be equivalent. In the end, I decided that it should look like my unit test was written for it but it brought my commit for False in instead. I made a PR to revert this one and another PR that corrects this error. my local tests didn't catch this because locally I had the correct result set and I somehow didn't catch what was pushed up before I opened the PR. my apologies. |
|
@FengchiW So is there something to do? Any open PullRequest or is it already all done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for the case where the
distancebetween theobserverandtargetis zero the function will crash with a Division by Zero Error. This error can happen if someone designs a chasing enemy that ends up at the players location. I added a check will return True indicating there is line of sight in such a case.Perhaps this should instead be a configurable option?
Additionally, the Line of Sight function did not ensure that we have a positive non-zero value for the check resolution. I added a check that will raise a value error in such a case.