Skip to content

Fix exception types in arcade.sound #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Oct 16, 2023

Changes

  1. Use TypeError instead of ValueError when the wrong types are passed to sound helpers
  2. Add unit tests to verify this + helper text phrasing
  3. Turn a raise into a raise from
  4. Rephrase some exceptions and restructure their generation

The items in 4 are generally well-separated out and easy to revert, and I can understand if reviewers think we should do that.

This is a follow-up to some reading done for #1922.

Copy link
Member

@eruvanos eruvanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after the small fix

@pushfoo pushfoo requested a review from eruvanos November 8, 2023 22:57
@eruvanos eruvanos merged commit e3034ec into pythonarcade:development Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants