Fixed PyRight issues. #1854
Merged
Fixed PyRight issues. #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of PyRight is a little over zealous.. There where two flagged non-issues. One where it didn't realise that the code would escape early, and another which is all pyglets fault.
cspotcode
reviewed
Aug 6, 2023
There was a problem hiding this comment.
When # type: ignore is due to pyglet issues, we have a convention of adding a comment linking to the pyglet issue. Should we keep that convention? You can search for # pending to see it.
For example: https://github.com/pythonarcade/arcade/blob/development/arcade/sound.py#L143
cspotcode
reviewed
Aug 10, 2023
cspotcode
force-pushed
the
fix-SimpleSprite-Issue
branch
3 times, most recently
from
9c771b9 to
a51173c
Compare
cspotcode
force-pushed
the
fix-SimpleSprite-Issue
branch
from
a51173c to
b6aa75a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of PyRight is a little over zealous.. There where two flagged non-issues. One where it didn't realise that the code would escape early, and another which is all pyglets fault.