Solution for problem with rotation in tiled ? #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, when the rotation is not 180, the position disagree between tiled and arcade.
It failed for now: the rotation is done in the wrong direction.
Changing some test to fix this. All test are now green. Probably fix pythonarcade#1805
vanicat
changed the title
|
This does in fact solve #1805 |
|
I've submitted this pull request some time ago now. Is-there something I should do to make it go forward ? Thanks. |
|
Sorry for the long wait on this one, I've been out of commission on Arcade for a while, looks good though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several test for rotation, and probable fix for #1805
A sign had to be changed in the tiled loader.
I've add to the :fixtures:tilemaps/rotation.json an object layer, with object that are tile, and are rotated. And arcade do not place some of the rotated tile correctly.
I believe that this is related to #1805, but I didn't not check for the correct direction of the rotation yet.