Hitbox rotate fix

arcade/hitbox/base.py

@@ -257,7 +257,7 @@ def get_adjusted_points(self) -> PointList:
         if not self._adjusted_cache_dirty:
             return self._adjusted_points
 
-        rad = radians(self._angle)
+        rad = radians(-self._angle)
         rad_cos = cos(rad)
         rad_sin = sin(rad)
 

tests/unit/htibox/test_hibox.py

@@ -0,0 +1,52 @@
+import pytest
+from arcade import hitbox
+
+points = [(0.0, 0.0), (0.0, 10.0), (10.0, 10.0), (10.0, 0.0)]
+rot_90 = [(0.0, 0.0), (10.0, 0), (10.0, -10.0), (0.0, -10.0)]
+
+
+def test_module():
+    # Make sure the module is loaded
+    assert hitbox.algo_default
+    assert hitbox.algo_detailed
+    assert hitbox.algo_simple
+    assert hitbox.algo_bounding_box
+
+
+def test_create():
+    hb = hitbox.HitBox(points)
+    assert hb.points == points
+    assert hb.get_adjusted_points() == points
+    assert hb.position == (0.0, 0.0)
+    assert hb.scale == (1.0, 1.0)
+    assert hb.bottom == 0.0
+    assert hb.top == 10.0
+    assert hb.left == 0.0
+    assert hb.right == 10.0
+
+
+def test_scale():
+    hb = hitbox.HitBox(points)
+    hb.scale = (2.0, 2.0)
+    assert hb.scale == (2.0, 2.0)
+    assert hb.get_adjusted_points() == [(0.0, 0.0), (0.0, 20.0), (20.0, 20.0), (20.0, 0.0)]
+
+
+def test_position():
+    hb = hitbox.HitBox(points)
+    hb.position = (10.0, 10.0)
+    assert hb.position == (10.0, 10.0)
+    assert hb.get_adjusted_points() == [(10.0, 10.0), (10.0, 20.0), (20.0, 20.0), (20.0, 10.0)]
+
+
+def test_create_rotatable():
+    hb = hitbox.HitBox(points)
+    rot = hb.create_rotatable()
+    assert rot.angle == 0.0
+    assert rot.position == (0.0, 0.0)
+    rot.angle = 90.0
+    assert rot.angle == 90.0
+
+    rot_p = rot.get_adjusted_points()
+    for i, (a, b) in enumerate(zip(rot_90, rot_p)):
+        assert a == pytest.approx(b), f"[{i}] {a} != {b}"

tests/unit/htibox/test_hitbox.py → tests/unit/htibox/test_hitbox_algo_legacy.py

@@ -3,14 +3,6 @@
 from PIL import Image
 
 
-def test_module():
-    # Make sure the module is loaded
-    assert hitbox.algo_default
-    assert hitbox.algo_detailed
-    assert hitbox.algo_simple
-    assert hitbox.algo_bounding_box
-
-
 def test_calculate_hit_box_points_simple():
     # Completely filled RGBA image
     image = Image.new("RGBA", (100, 100), (255, 255, 255, 255))