Skip to content

UI: do not render if UILayout text stays the same #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023
Merged

UI: do not render if UILayout text stays the same #1817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions arcade/gui/widgets/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,16 @@ def text(self):

@text.setter
def text(self, value):
self.label.text = value
self._update_layout()
self.trigger_full_render()
"""
Update text of the label.

This triggers a full render to ensure that previous text is cleared out.
"""

if self.label.text != value:
self.label.text = value
self._update_layout()
self.trigger_full_render()

def _update_layout(self):
# Update Pyglet layout size
Expand Down